Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VO:0005504 - vaccine for pathogen #622

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Sep 24, 2023

Part of #619.

Similarly to #620, this pull request adds a mid-level grouping term between VO:0000001 (vaccine) and four child terms:

  1. fungal vaccine
  2. bacterial vaccine
  3. protozoan vaccine
  4. virus vaccine

This is added in the term "vaccine for pathogen" (VO:0005504). It has the axiom immunizes against microbe' some 'organism' as a reminder that all subclasses of this term should include a statement saying specifically which taxa they immunize against

Finally, this PR adds a domain (vaccine) and range (organism) annotation to immunizes against microbe

Similarly to vaccineontology#620, this pull request adds a mid-level grouping term between VO:0000001 (vaccine) and four child terms:

1. fungal vaccine
2. bacterial vaccine
3. protozoan vaccine
4. virus vaccine

This is added in the term "vaccine for pathogen" (VO:0005504). It has the axiom `immunizes against microbe` some 'organism'` as a reminder that all subclasses of this term should include a statement saying specifically which taxa they immunize against

Finally, this PR adds a domain (vaccine) and range (organism) annotation to `immunizes against microbe`
@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 24, 2023

cc @yongqunh @Huffmaar

@cthoyt cthoyt changed the title Add grouping "vaccine for pathogen" Add VO:0005504 vaccine for pathogen Sep 24, 2023
@cthoyt cthoyt changed the title Add VO:0005504 vaccine for pathogen Add VO:0005504 - vaccine for pathogen Sep 24, 2023
@Huffmaar
Copy link
Contributor

Huffmaar commented Sep 25, 2023 via email

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 3, 2023

hi @Huffmaar @yongqunh, can we please merge this?

@Huffmaar
Copy link
Contributor

Huffmaar commented Oct 3, 2023

We have some other updates that we want to combine into one merge sometime later today.

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 3, 2023

@Huffmaar I don't understand, is this contribution dependent on something else I am unaware of?

@Huffmaar
Copy link
Contributor

Huffmaar commented Oct 3, 2023

In this case, the merge is fine. I just plan on merging multiple branches today, and was planning on combining them into one update/mega-merge.
Sorry for the confusion.

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 3, 2023

@Huffmaar I am pretty experienced with git, and I would highly suggest against doing that. It's much better and more explainable when you go through the history on the main branch to see that commits correspond to PRs with well-defined, high level goals

@Huffmaar Huffmaar merged commit cd5e732 into vaccineontology:master Oct 3, 2023
@Huffmaar
Copy link
Contributor

Huffmaar commented Oct 3, 2023

Understood; I had previously relied on @yongqunh to authorize/review any changes. As I do not see any conflicts, I am Merging now.

@cthoyt cthoyt deleted the vaccine-by-platform branch October 3, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants